[cairo] [PATCH 2/2] xlib-surface fix

Carl Worth cworth at cworth.org
Fri Aug 5 06:43:16 PDT 2005


On Thu, 4 Aug 2005 22:16:44 -0400, Jeff Muizelaar wrote:
> The following patch replaces the incorrect use of buffer_diff on a
> CAIRO_FORMAT_RGB24 buffer with the new function buffer_diff_noalpha from
> the previous patch.

The patches look fine in general. Thanks!

The one comment I have is that rather than buffer_diff and
buffer_diff_noalpha it seems like it might be preferable to have the
test code pass a cairo_format_t to the comparison function.

-Carl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/cairo/attachments/20050805/f599e760/attachment.pgp


More information about the cairo mailing list