[cairo] [PATCH] fix _cairo_rectangle_intersect

Kristian Høgsberg krh at bitplanet.net
Sun Feb 27 11:33:04 PST 2005


Jeff Muizelaar wrote:
> _cairo_rectangle_intersect gives bad results whenever
> MIN (dest->x + dest->width, src->x + src->width) - out.x
> is negative because of assignment to an unsigned short.
> 
> The appended patch fixes the problem by using variables of type int for
> the computation results.

Thanks, good catch.  I've committed a slightly different patch 
(basically what David suggested) which should give correct results for 
all valid input rectangles.

cheers,
Kristian



More information about the cairo mailing list