[cairo] Error handling patch

Behdad Esfahbod behdad at cs.toronto.edu
Thu Jul 28 06:36:55 PDT 2005


Hi Carl,

Do you think all these if (something->state) checks are worth
adding G_UNLIKELY hints to?  I don't know enough about the
hardware, is such a hint at the beginning of a function any
useful?

behdad


On Thu, 28 Jul 2005, Carl Worth wrote:

> On Wed, 27 Jul 2005 16:57:00 -0700, Carl Worth wrote:
> > So I'll go through and rip out all the create_in_error stuff.
>
> Here's a patch to do it. It's rather straightforward I think.
>
> I've gotten rid of the ugly pattern that was intended to prevent a
> surface_create_similar function from calling create_in_error as well.
>
> And I've made things a bit more clear in that when the code does check
> surface->status after a surface_create function it always returns
> CAIRO_STATUS_NO_MEMORY rather than surface->status.
>
> -Carl

--behdad
http://behdad.org/



More information about the cairo mailing list