[cairo] Error handling patch

Owen Taylor otaylor at redhat.com
Thu Jul 28 09:19:55 PDT 2005


On Thu, 2005-07-28 at 09:03 -0700, Carl Worth wrote:
> On Wed, 27 Jul 2005 20:06:55 -0400, Owen Taylor wrote:
> > Here's a patch for this - it was pretty straightforward since font faces
> > are by definition immutable. Like everything else here, the new code
> > paths aren't really tested, but it seems to work fine when no errors
> > are occurring.
> 
> Thanks.
> 
> > @@ -791,6 +831,9 @@ cairo_scaled_font_create (cairo_font_fac
> >      cairo_cache_t *cache;
> >      cairo_status_t status;
> >  
> > +    if (font_face->status)
> > +	return (cairo_scaled_font_t*) &_cairo_scaled_font_nil;
> > +
> 
> Missing:
> 
> 	_cairo_error (font_face->status);
> 
> here?
> 
> Or, maybe not, because this isn't a root cause error?

That was my thought.

I've committed the patch as is.
							Owen

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.freedesktop.org/archives/cairo/attachments/20050728/81c0b26c/attachment.pgp


More information about the cairo mailing list