[cairo] Solid color pattern constructors

[Carl Worth]

On Tue, 28 Jun 2005 15:45:58 -0400, Kristian Høgsberg wrote:
> Here's a patch to add constructors for solid color patterns:

Great! This will be quite handy to have, and fills an obvious hold in
the API.

> +/**
> + * cairo_pattern_create_rgb:
[...]
> + * Create a new cairo_pattern_t corresponding to a solid, opaque
> + * color.

> +/**
> + * cairo_pattern_create_rgba:
[...]
> + * Create a new cairo_pattern_t corresponding to a solid, opaque
> + * color.

Obviously the second version shouldn't have "opaque" in it as already
mentioned.

And while the implementation does use "solid" for these kinds of
patterns, it's not clear to me that that's the best word here,
(particularly since some users may read "solid" as a synonym for
"opaque").

When I documented set_source_rgb[a] I left "solid" out. So maybe this
would be sufficient:

	cairo_pattern_create_rgb
	Creates a cairo_pattern_t for an opaque color.

	cairo_pattern_create_rgba
	Creates a cairo_pattern_t for a translucent color.

(or similar). Otherwise, please commit.

Thanks.

-Carl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/cairo/attachments/20050628/9dd3bb0d/attachment.pgp