[cairo] libsvg memory mis-management in patterns

Carl Worth cworth at cworth.org
Thu May 12 16:34:23 PDT 2005


On Wed, 11 May 2005 22:03:32 -0700, Keith Packard wrote:
> I think this is wrong -- it will use the same group_element for both
> patterns.

Yes.

> I think this is wrong -- it should call

Yes.

> Anyone have different opinions?

Nope, just my lousy code.

While you're at it, if you'd care to replace the *pattern = *other
with explicit field-by-field copies that would be fine too. That
nonsense has been the source of multiple bugs in other _init_copy
functions, (and likely still exists in others).

-Carl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/cairo/attachments/20050512/184a19ed/attachment.pgp


More information about the cairo mailing list