[cairo] Cleaning up the PDF API

Kristian Høgsberg krh at bitplanet.net
Tue May 17 09:28:48 PDT 2005


On Tue, 2005-05-17 at 01:30 -0700, Carl Worth wrote:
> On Mon, 16 May 2005 21:22:19 -0700, Carl Worth wrote:
> > With that in place, the surface is only finished on an explicit user
> > action, (cairo_surface_finish), or asynchronously when the surface is
> > destroyed, (for which we already have user_data callbacks). The
> > argument above makes it sound like the user can't know when the
> > surface is going to be finished, which just isn't the case. (Or if it
> > were, perhaps we could just use always use this callback and drop the
> > cairo_surface_finish call --- not that I would actually prefer that
> > approach).
> 
> I'm now attempting a filibuster approach to this problem.
> 
> I seem to have stayed awake longer than anyone else involved in this
> debate, so my message above now seems to be the final word, (even if
> only because everyone else has gone to sleep).

If we're doing this, we need to fclose the FILE some other way.  I've
attached a patch that fixes this and also fixes another problem I
randomly spotted.  The output stream is referenced after it's destroyed
to get the status.

cheers,
Kristian

-------------- next part --------------
A non-text attachment was scrubbed...
Name: pdf-fixes.patch
Type: text/x-patch
Size: 3104 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/cairo/attachments/20050517/ef313977/pdf-fixes.bin


More information about the cairo mailing list