[cairo] clipping bug
Jason Dorje Short
jdorje at users.sf.net
Mon Sep 12 11:05:03 PDT 2005
Radek Doulík wrote:
> On Wed, 2005-08-31 at 09:08 -0700, Carl Worth wrote:
>
>>On Thu, 25 Aug 2005 15:22:01 +0200, Radek Doulík wrote:
>>
>>>I prepared a fix which stops compositing even earlier. That way it will
>>>not hide other bugs, where compositing with zero width or height. It is
>>>included in the new patch.
>>
>>There's a style change I'd like to see for this bug fix. What I would
>>like to see is:
>>
>> if (nothing_to_do)
>> return; /* or GOTO perhaps */
>>
>>rather than:
>>
>> if (! nothing_to_do) {
>> /* Big existing block now indented more. */
>> }
>>
>>I've got some notes on this general style point in cairo/CODING_STYLE.
goto is uglier than a long if block. If indentation is too much or the
block is too long a helper function can be used.
-jason
More information about the cairo
mailing list