[cairo] [PATCH] Reset dashing for new subpaths.

Carl Worth cworth at cworth.org
Mon Apr 10 11:07:38 PDT 2006

On Sun, 9 Apr 2006 23:13:36 -0400, Jeff Muizelaar wrote:
> Fixes the bug mentioned in b87726ee2aa0220b66ee4d97513c0ac89ffc4621 by reseting
> the dash pattern for each new subpath. This is correct behaviour according to
> the end of PDF Reference v1.6 section 4.3.2. This patch applies on top of the
> zero length dashing patches.
> ---
> diff --git a/src/cairo-path-stroke.c b/src/cairo-path-stroke.c

Fantastic, Jeff!

I love being able to have the test suite back to 100% passing, so I
went ahead and pushed this change out to the central cairo tree
(without waiting for any of your other dashing patches).

And if you look closely, you'll see that I followed the order I
suggested in an earlier mail, (I first committed the new reference
images to make the test fail, then I committed the code changes to
make the tests pass again).


PS. In your commit message above, the last sentence, ("This patch
applies..."), is a meta-instruction to a committer, rather than an
essential part of the description of the commit.

The git-am script has support for ignoring such transient information,
since it's not useful to have it frozen for all time in the commit

The trick is to leave such stuff off when making the commit, and then
type it into the email message between the "---" separator and the
beginning of the patch itself.

As was, I did the following to apply the patch and then re-write the
commit message before pushing it out:

| git-am		# from within my MUA
git reset --soft HEAD^	# Undo the commit, but keep the change in tree
git commit -c ORIG_HEAD # Redo the commit, and edit the original message
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/cairo/attachments/20060410/ba917d0c/attachment.pgp

More information about the cairo mailing list