[cairo] [PATCH] Allow hash entry deletion during cairo_hash_foreach

Carl Worth cworth at cworth.org
Tue Apr 11 11:04:39 PDT 2006


On Tue, 11 Apr 2006 10:41:37 -0700, Keith Packard wrote:
>
> > It may be worth throwing one of these:
> > 
> > 	/* No iterators can be running. Otherwise, halt. */
> > 	assert (hash_table->iterating == 0);
> 
> I actually removed that check, but can put it back if you like.

It's certainly not a requirement. It's easy to hit diminishing returns
with assert statements and readability.

We don't expect a lot of churn in this code, so let's call it good as
is.

-Carl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/cairo/attachments/20060411/ee76f589/attachment.pgp


More information about the cairo mailing list