[cairo] [PATCH] Fix Analysis Surface Memleak

Dominic Lachowicz domlachowicz at gmail.com
Thu Apr 27 05:40:39 PDT 2006

Instead of introducing new API, maybe it would be better to instead
implement surface_backend->finish_surface for the analysis surface if
it's leaking memory. It would look something like the attached patch,
with the "code goes here" part filled in.


On 4/27/06, Henning Noren <henning.noren.402 at student.lu.se> wrote:
> I forgot to say that it is against the latest git, and that I'm not
> quite sure about the last part of the patch. That is what you get for
> hitting the send-button too fast.
> Please double check that the second _cairo_analysis_surface_destroy
> really is needed. All test seems to pass fine but I'm not that familiar
> with the code.
> Sincerely
> Henning
> On Thu, 2006-04-27 at 10:21 +0200, Henning Noren wrote:
> > This patch fixes a obvious memleak and by that removes 2000 lines of
> > output from 'make chech-valgrind'.
> >
> > /Henning
> _______________________________________________
> cairo mailing list
> cairo at cairographics.org
> http://cairographics.org/cgi-bin/mailman/listinfo/cairo

Counting bodies like sheep to the rhythm of the war drums.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: analysis-surface-memleak.patch
Type: text/x-patch
Size: 819 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/cairo/attachments/20060427/f64cf894/analysis-surface-memleak.bin

More information about the cairo mailing list