[cairo] [PATCH 7/8] Missing value for the "clip" field, comments are off-by-one

Behdad Esfahbod behdad at behdad.org
Sun Aug 13 02:05:06 PDT 2006


This is nasty.  And the fact that most of the fields are zero makes
errors in the initialization to show really late.  I suggest we switch
to named initializers.  Any cons to that?  Any compilers that compile
cairo but don't support them?

behdad

On Sun, 2006-08-13 at 01:58 -0400, Pavel Roskin wrote:
> From: Pavel Roskin <proski at gnu.org>
> 
> Signed-off-by: Pavel Roskin <proski at gnu.org>
> ---
> 
>  src/cairo-surface.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/src/cairo-surface.c b/src/cairo-surface.c
> index 3fd9176..686c084 100644
> --- a/src/cairo-surface.c
> +++ b/src/cairo-surface.c
> @@ -63,6 +63,7 @@ const cairo_surface_t _cairo_surface_nil
>      },					/* device_transform_inverse */
>      0.0,				/* x_fallback_resolution */
>      0.0,				/* y_fallback_resolution */
> +    NULL,				/* clip */
>      0,					/* next_clip_serial */
>      0					/* current_clip_serial */
>  };
> @@ -89,6 +90,7 @@ const cairo_surface_t _cairo_surface_nil
>      },					/* device_transform_inverse */
>      0.0,				/* x_fallback_resolution */
>      0.0,				/* y_fallback_resolution */
> +    NULL,				/* clip */
>      0,					/* next_clip_serial */
>      0					/* current_clip_serial */
>  };
> @@ -115,6 +117,7 @@ const cairo_surface_t _cairo_surface_nil
>      },					/* device_transform_inverse */
>      0.0,				/* x_fallback_resolution */
>      0.0,				/* y_fallback_resolution */
> +    NULL,				/* clip */
>      0,					/* next_clip_serial */
>      0					/* current_clip_serial */
>  };
> _______________________________________________
> cairo mailing list
> cairo at cairographics.org
> http://cairographics.org/cgi-bin/mailman/listinfo/cairo
-- 
behdad
http://behdad.org/

"Commandment Three says Do Not Kill, Amendment Two says Blood Will Spill"
        -- Dan Bern, "New American Language"



More information about the cairo mailing list