[cairo] [PATCH 6/8] Don't use bare #if on possibly undefined
preprocessor symbols
Pavel Roskin
proski at gnu.org
Sun Aug 13 02:52:03 PDT 2006
On Sun, 2006-08-13 at 04:50 -0400, Behdad Esfahbod wrote:
> On Sun, 2006-08-13 at 01:57 -0400, Pavel Roskin wrote:
> > From: Pavel Roskin <proski at gnu.org>
> >
> > When testing for symbols from Autoconf-generated config.h, we should
> > test for is whether the symbol is defined.
>
> This one I wanted to do too, but Carl doesn't like it. The problem with
> using ifdef of course is that defining something to zero doesn't turn it
> off.
Actually, this patch only makes such change for the symbols starting
with "HAVE_", which come from Autoconf generated config.h. It doesn't
affect other symbols that may have a different semantic. I was only
getting warnings about "HAVE_" symbols.
> I decided to take the warning flag out of my environment instead.
That's why a reference to the non-existent __INT_MIN__ was never found.
--
Regards,
Pavel Roskin
More information about the cairo
mailing list