[cairo] src surface clip problems

Carl Worth cworth at cworth.org
Thu Aug 17 13:38:42 PDT 2006


On Tue, 8 Aug 2006 15:02:50 -0700, "Vladimir Vukicevic" wrote:
> Here's a patch for pixman that -I think- fixes this -- all the generic
> "fetch" functions were using pCompositeClip, when I think they should
> be using pSourceClip.

The patch looks good to me, so I've just pushed it out.

>  With this change, it makes the test case work,
> and the rest of the test suite passes (I think -- I have some failures
> due to font differences on win32, but visually they look correct).
> This has gotten zero testing outside of this though, so I don't know
> how confident I am in this.  In theory, we should be able to just get
> rid of pSourceClip entirely as well (and get rid of all these checks
> from pixman).

Yes, dropping this dead code from pixman would be a (very small)
improvement to that code. I'm postponing that until after 1.2.4 is
out, (or someone comes along with something to make pixman
irrelevant...).

-Carl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/cairo/attachments/20060817/2252781c/attachment.pgp


More information about the cairo mailing list