[cairo] [PATCH] OS/2 backend support files

[Behdad Esfahbod]

On Mon, 2006-07-31 at 17:27 -0400, Peter Weilbacher (Mozilla) wrote:
> On Sat, 29 Jul 2006 10:28:56 +0300, Kalle Vahlman wrote:
> 
> >2006/7/29, Peter Weilbacher (Mozilla) <mozilla at weilbacher.org>:
> >> I still have no clue where the "png_CFLAGS" are coming from but it probably
> >> has something to do with the autotools magic, I see none of them in
> >> configure.in but lots of them in configure (even though they don't appear in
> >> the dir with all the autotools), e.g. the line
> >>   png_CFLAGS  C compiler flags for png, overriding pkg-config
> >
> >Yes, this is due to calling
> >
> >  PKG_CHECK_MODULES(png, $png_REQUIRES)
> >
> >which automatically defines envvars like png_CFLAGS and png_LIBS. Also
> >noticed that the backend testing uses mixed case variable elsewhere
> >too and while I'm not sure I decrypted the (impressive looking, I
> >might add ;) autofoo used there right, I bet there is more of them
> >generated automatically from them.
> >
> >I guess those should be changed if it creates problems for some platforms?
> 
> OK, attached is the small patch to do that, but for now only for the PNG-related 
> variables. (In the "./configure --help" output I see that the same occurs for 
> xlib_xrender, xcb, glitz, and directfb. I could include the changes for those, 
> too, if wanted.)

This ain't gonna work.  You should at least make sure you know where
this is being used and update that too!  The png_CFLAGS/etc are used by
the CAIRO_BACKEND_ENABLE macro and they should match the first parameter
passed to that macros.  So, if you want to change png_CFLAGS to
PNG_CFLAGS, you need to update other places too.  And currently that
macro doesn't support that, as the first argument has got to be in lower
case.  So, to fix your problem, you need to add yet another argument to
that macro and update all the rest of configure.in to use that.

>    Peter.

-- 
behdad
http://behdad.org/

"Commandment Three says Do Not Kill, Amendment Two says Blood Will Spill"
        -- Dan Bern, "New American Language"