[cairo] cairo-1.1.6, patch for pixman library

[Carl Worth]

On Wed, 7 Jun 2006 18:32:16 +0400 (MSD), Zakharov Mikhail wrote:
> I tried to compile cairo-1.1.6 under HP-UX 11.11 on a hppa1.1 box with
> gcc-4.1.0. Process failed with errors in
> cairo-1.1.6/pixman/src/pixman.h. This simple patch fixes the
> problem.

Thanks. This is pushed out now:

http://gitweb.cairographics.org/?p=cairo;a=commit;h=32c0e85d45ee26c34ba1af0e4ba6ced044e469cc

It occurs to me that what should really be done is to stop doing this
platform detection and just use HAVE_STDINT as in src/cairo-wideint.h,
(the reason we didn't do this originally is that pixman.h had been
intended to be an installed public header where things like
HAVE_STDINT are not available, but that's certainly not the case
anymore now that pixman is absorbed as part of cairo and not an
external library).

-Carl

PS: The patch didn't apply easily with git-am like I would have liked
it to. This is because it was generated down at the pixman/src
directory and not up at the top-level. It would be good for someone to
put together a little guide on how to submit patches to cairo.

That could even mention things like formatting the email so that
git-am finds a perfect commit message in it. This means:

1) Making the subject be a commit message headline (an initial [PATCH]
   is fine and will be stripped by git-am).

2) Making the first paragraphs of the mail be a more detailed commit
   message, explaining what the patch does.

3) Further exposition in the email that should not be part of the
   commit message, (such as requests for review, or things like "this
   patch should be applied only after my previous patches...", etc.)
   should be separated by a line consisting of "-- ".

That kind of formatting is extra nice, but it's not essential. For
example the email here didn't have it, but that's pretty easy to fix
up after the fact with "git commit --amend". But when the patch
doesn't apply at all with git-am then it's a lot harder to work with.

Oh, and of course, the easiest way to get all of the above formatting
right is to use git to commit locally and then use "git
format-patch". That obviously isn't as directly helpful for someone
working with a tar-file version of cairo of course.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/cairo/attachments/20060607/14c8a3a1/attachment.pgp