[cairo] Re: fontconfig-antialias doesn't work and missing characters in cairo 1.1.10

[Carl Worth]

On Mon, 19 Jun 2006 23:57:44 +0800, sunmoon1997 wrote:
> The patch fixed the first problem for me.

Thanks so much! I had recently committed effectively the same patch,
but I had missed this bit:

> diff --git a/src/cairo-xlib-surface.c b/src/cairo-xlib-surface.c
> index f10d2f4..c4b3f6e 100644
> --- a/src/cairo-xlib-surface.c
> +++ b/src/cairo-xlib-surface.c
> @@ -2658,14 +2658,12 @@ _cairo_xlib_surface_show_glyphs (void   
>                                                            glyphs,
>                                                            num_glyphs,
>                                                            &glyph_extents);
> -        if (status)
> -            return status;
> -
> -        status = _cairo_pattern_acquire_surface (src_pattern, &dst->base,
> -                                                 glyph_extents.x, glyph_extents.y,
> -                                                 glyph_extents.width, glyph_extents.height,
> -                                                 (cairo_surface_t **) &src,
> -                                                 &attributes);
> +        if (status == CAIRO_STATUS_SUCCESS)
> +	    status = _cairo_pattern_acquire_surface (src_pattern, &dst->base,
> +						     glyph_extents.x, glyph_extents.y,
> +						     glyph_extents.width, glyph_extents.height,
> +						     (cairo_surface_t **) &src,
> +						     &attributes);

For which I've now committed a slightly different fix. Simply doing:

	if (status)
	    goto BAIL;

-Carl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/cairo/attachments/20060625/88341c00/attachment.pgp