[cairo] cairo_get_clip_as_rectangles
Robert O'Callahan
rocallahan at novell.com
Thu Jun 29 15:32:13 PDT 2006
On Thu, 2006-06-29 at 12:21 -0400, Kristian Høgsberg wrote:
> On 6/28/06, Carl Worth <cworth at cworth.org> wrote:
> > On Wed, 28 Jun 2006 17:06:57 +1200, Robert O'Callahan wrote:
> > >
> > > Attached is a patch for my next attempt at getting the clip as a
> > > rectangle list.
> ...
> > > + * If the output *is_tight is set to true, then the union is exactly
> > > + * the clip area. (If *is_tight is false, the union may or may not be exactly
> > > + * the clip area.)
> >
> > The wording here is a bit awkward as it might suggest that the user
> > needs to set is_tight to TRUE or FALSE before calling the function,
> > (perhaps as a hint for what they want). Maybe something like:
> >
> > The @is_tight parameter is used as a return value to indicate
> > whether the returned rectangles are a tight bound on the clip
> > region or not. A tight bound does not include any pixels not
> > in the clip region. It is valid to pass a NULL pointer if the
> > caller is not interested in the tightness.
>
> Shouldn't this be even stricter: "does not include any pixels not
> completely covered by the clip region". Or maybe drop the double
> negative: "A thight bound only includes pixels completely covered by
> the clip region".
Wording about pixels is misleading because it's possible to have a tight
result that partially covers some pixels.
Anyway, this parameter is going away in the next revision so it's not an
issue.
Rob
More information about the cairo
mailing list