[cairo] Bug in _cairo_xlib_surface_create_similar

Robert O'Callahan rocallahan at novell.com
Thu May 18 19:07:43 PDT 2006


On Thu, 2006-05-18 at 16:48 -0700, Carl Worth wrote:
> On Fri, 19 May 2006 11:27:25 +1200, Robert O'Callahan wrote:
> > But don't you want to remove your CAIRO_SURFACE_RENDER_HAS_COMPOSITE
> > check from _cairo_xlib_surface_create_similar_with_format, too?
> 
> *shrug*
> 
> It'd really be just guessing on my part. And I don't like to guess
> about performance changes. If anyone around here really cares about
> cairo performance on non-Render X servers, then they could work on
> taking out some of the guesswork, (though this particular issue is
> likely not anything like the most important performance issue for
> cairo on non-Render X servers).

Okay, but realize that these patches do change
cairo_surface_create_similar for non-Render X servers, now that we've
removed the CAIRO_SURFACE_RENDER_HAS_COMPOSITE check from my new code.

Rob



More information about the cairo mailing list