[cairo] local PLT check failure for cairo-xcb

[Behdad Esfahbod]

On Mon, 2006-10-02 at 15:41 -0400, Jamey Sharp wrote:
> On Sat, Sep 30, 2006 at 12:34:05PM -0700, Jamey Sharp wrote:
> > Checking .libs/libcairo.so for local PLT entries
> > 0005e784  00014307 R_386_JUMP_SLOT   00034af0   cairo_xcb_surface_crea
> > FAIL: check-plt.sh
> > 
> > After looking at cairo-xlib-private.h, I tried adding this line just
> > after the #include directives in cairo-xcb-surface.c:
> > 
> > slim_hidden_proto (cairo_xcb_surface_create_with_xrender_format);
> > 
> > but that pushed the error to an earlier test:
> > 
> > Checking cairo.def
> > 222d221
> > < cairo_xcb_surface_create_with_xrender_format
> > FAIL: check-def.sh
> > 
> > How does this work? cairo_xcb_surface_create_with_xrender_format is used
> > inside the implementation but is also public.
> 
> On Mon, Oct 02, 2006 at 02:39:10PM -0400, Behdad Esfahbod wrote:
> > This means that for some reason that symbols is not correctly find its
> > way into cairo.def.  Check why's that.  It all looks correct here.
> 
> Thanks for the reply, Behdad, but I don't think you addressed my
> question. The cairo.def failure only happened after I tried to use
> slim_hidden_proto to address the check-plt failure. Without
> slim_hidden_proto, cairo.def is fine, as you observed.

Your slim_hidden_proto is correct.  Seems like you didn't add
slim_hidden_def after the function definition.  Doing that should fix
the other test too.

behdad

> --Jamey

-- 
behdad
http://behdad.org/

"Commandment Three says Do Not Kill, Amendment Two says Blood Will Spill"
        -- Dan Bern, "New American Language"