[cairo] local PLT check failure for cairo-xcb

[Carl Worth]

On Thu, 12 Oct 2006 10:55:36 -0700, Jamey Sharp wrote:
> On Wed, Oct 11, 2006 at 09:44:57PM -0700, Ian Osgood wrote:
> > This patch brings cairo XCB backend up to XCB RC2.
>
> On Wed, Oct 11, 2006 at 09:48:38PM -0700, Ian Osgood wrote:
> > This patch replaces some bad code with a renderutil library function.
>
> I've reviewed and pushed these. Thanks, Ian!

Thanks to both Ian and Jamey!
>
> I'd like to recommend that Ian have commit access to cairo. He's clearly
> demonstrated that he doesn't need my review, and since he's an active
> committer for XCB he's well suited to work on the XCB backend for cairo.

Agreed. And done.

> and 'make check' works now, except it caused my X server to segfault in
> a CompositeTrapezoids call. Guess I'll be filing a bug report about
> that. :-)

Oh, my. Mozilla has seen that call crash due to exceeding the number
of trapezoids sent or something like that:

	https://bugzilla.mozilla.org/show_bug.cgi?id=356372
	https://bugzilla.mozilla.org/show_bug.cgi?id=307254

Which is odd since CompositeTrapezoids is supposed to break things up
into bite-size batches for the X server.

Meanwhile, the batching breaks the cairo semantics anyway, (it
introduces seams), so we've been needing to switch to AddTraps since
it was first added to Render, (and that will likely get us better
performance anyway).

Still, I certainly haven't seen "make check" crash any of my X
servers, so it would be good to track down that bug and fix it.

-Carl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/cairo/attachments/20061012/66207a68/attachment.pgp