[cairo] implement clone_similar fallback

Carl Worth cworth at cworth.org
Mon Aug 27 16:07:46 PDT 2007

On Mon, 27 Aug 2007 15:44:57 -0700, Vladimir Vukicevic wrote:
> similar_scratch, but composite() failed for whatever reason -- I don't
> want to return a surface in clone_out *and* return an error (from
> composite), because then the caller would have to know to call
> surface_destroy() on clone_out even if the fallback method returns an
> error.  That seems wrong to me;

Yes, I agree. I missed that case when I suggested code without the

> But, the null-check can definitely go

OK, that's all I was really intending to comment on. The further
(incorrect) simplification I gave was just an afterthought.

> Yep; I've changed some other stuff in cairo_surface_clone_similar as
> well, I'll post a new patch when we get the above issue resolved.

Sounds good. Keep up the great work!

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.cairographics.org/archives/cairo/attachments/20070827/8e7e816e/attachment.pgp 

More information about the cairo mailing list