[cairo] [PATCH] Fix version check for buggy_repeat on modular Xserver 1.x

[Kalle Vahlman]

2007/12/5, Bernardo Innocenti <bernie at codewiz.org>:
> The versioning of the X server has restarted from 1.0 in the
> modular build.  So we adjust the text to avoid considering
> the new servers buggy.
> ---
>  src/cairo-xlib-display.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/src/cairo-xlib-display.c b/src/cairo-xlib-display.c
> index efb53ba..6b389e5 100644
> --- a/src/cairo-xlib-display.c
> +++ b/src/cairo-xlib-display.c
> @@ -292,7 +292,7 @@ _cairo_xlib_display_get (Display *dpy)
>
>      display->buggy_repeat = FALSE;
>      if (strstr (ServerVendor (dpy), "X.Org") != NULL) {
> -       if (VendorRelease (dpy) <= 60802000)
> +       if (VendorRelease (dpy) >= 60000000 && VendorRelease (dpy) <= 60802000)

We too have (at work) made this change to avoid the issue, though
starting with 60700000 ie. the first X.Org release. When we bumped
into this I tried to inquire what is the deal with the versioning
scheme:

  http://lists.freedesktop.org/archives/xorg/2007-October/028921.html

...but hit the stone wall of silence and eventually forgot the whole thing.

Short investigations showed that even normal distros (not just
hand-built) seemed to be hitting the buggy_repeat with the recent
X.Org, so I think the fix would really be worth it (even if it only
works around silly versioning changes).

-- 
Kalle Vahlman, zuh at iki.fi
Powered by http://movial.fi
Interesting stuff at http://syslog.movial.fi