[cairo] Making final cairo_show_page redundant
Carl Worth
cworth at cworth.org
Tue Feb 27 23:14:42 PST 2007
On Tue, 27 Feb 2007 21:45:27 -0500, Behdad Esfahbod wrote:
> In preparation for 1.4.0, I want to commit the attached patch to make a
> final cairo_show_page() unnecessary. Please review.
Fabulous! This is something I've been wanting for quite some
time. Thanks for actually sitting down and doing it, (you've been
doing that for a lot of little issues lately which I really
appreciate).
> + if (!surface->page_is_blank)
> + status = _cairo_paginated_surface_show_page (abstract_surface);
And isn't it great when a feature really is as simple as that?
I haven't run this at all, but it sure seems good to me.
> @@ -287,8 +287,6 @@ cairo_test_for_target (cairo_test_t *test,
> goto UNWIND_CAIRO;
> }
>
> - cairo_show_page (cr);
And this part ensures that the test suite picks up testing of the new
feature.
So, thanks again! Please push it out.
-Carl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/cairo/attachments/20070227/5c0f0dd8/attachment.pgp
More information about the cairo
mailing list