[cairo] [PATCH] _cairo_win32_surface_show_glyphs

Jonathan Watt jwatt at jwatt.org
Fri Jan 5 15:04:10 PST 2007


Behdad Esfahbod wrote:
> Hi Jonathan,
> 
> Since you've been hacking on this win32 font code, there are a couple of
> changes I can suggest, to bring the win32 show_glyphs in par with the
> latest changes I made in the show_glyphs API and the xlib surface.
> 
> First, since we were using stack buffers in a few places, I went on and
> defined CAIRO_STACK_BUFFER_SIZE.  See cairo-xlib-surface.c for example.
> 
> Next, you may notice that the cairo_glyph_t* parameter to show_glyphs is
> not const anymore.  This means, you are allowed to modify the contents
> as long as you don't return CAIRO_STATUS_UNSUPPORTED.  So, you may want
> to reuse that as one of your output buffers, dxy_buf for example.
> Again, you can check cairo-xlib-surface.c for an example.

Hi Behdad,

Thanks for the suggestions. I'd have a go at that if I didn't feel like I'm 
juggling too many things at once right now. (It also doesn't help that git gives 
me headaches whenever I try to do the "simplest" thing which makes me inclined 
to avoid it. It's a shame that git seems to make more advanced uses the default 
thereby requiring more detailed knowledge for the simple use cases. When I find 
the time I'll spend a few days learning how git works, then write some cairo git 
docs and come back to this (if no one else has addressed it by then).)

-Jonathan


More information about the cairo mailing list