[cairo] [PATCH] Make UTF-8 output from cairo-perf-diff-files optional.

Kalle Vahlman kalle.vahlman at gmail.com
Sat Jan 13 02:36:03 PST 2007


And here is the actual patch...

2007/1/13, Kalle Vahlman <kalle.vahlman at gmail.com>:
> 2006/12/19, Carl Worth <cworth at cworth.org>:
> > On Sat, 16 Dec 2006 22:21:36 +0200 (EET), M Joonas Pihlaja wrote:
> > > I'd like to push this patch that adds options to disable the
> > > UTF-8 change bars and replace them with ASCII '*' gfx.  UTF-8
> > > really does some damage to my terminal, and I always forget to
> > > pipe stuff through a pager to make it safe.
> >
> > I certainly can't complain about someone wanting to fix this program
> > so that it works in there environment. If I cared I might suggest an
> > option style such as "--bar-graph=[utf8|ascii|none]", but I really
> > don't care all that much. So do as you see fit.
>
> Then you might not object to having it work cross different hardware
> either, right?-)
>
> I ran cairo-perf on several different hardware and noticed that they
> couldn't be compared with cairo-perf-diff-files since it uses the
> ticks value for the comparison. The ticks can be very different on
> different hardware, so I added an option to use the ms value instead.
> This loses precision of course, but it should be small enough loss to
> not really matter.
>
> And getting something more or less descriptive is better than getting
> lied to outright, right?-) The diff for example described the 770 as
> over 800x faster than my 700MHz Celeron, which made me slightly
> skeptic on the result...
>
> I took the patch from Mr. Pihlaja (doesn't seem to be applied to git
> head) and added my option to that. If someone would be kind enough to
> check it and push it, I'd be greatful.
>
> More on the results a bit later.
>
> --
> Kalle Vahlman, zuh at iki.fi
> Powered by http://movial.fi
> Interesting stuff at http://syslog.movial.fi
>


-- 
Kalle Vahlman, zuh at iki.fi
Powered by http://movial.fi
Interesting stuff at http://syslog.movial.fi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: options-for-cairo-perf-diff.diff
Type: text/x-patch
Size: 7410 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/cairo/attachments/20070113/420a2a34/options-for-cairo-perf-diff-0001.bin


More information about the cairo mailing list