[cairo] issue with rotated image sources

[Carl Worth]

On Sat, 20 Jan 2007 12:37:55 +0100 (NFT), Benjamin Otte wrote:
> Now that I've written that, I just noticed that you use create_similar
> while swfdec does use an image surface.

Yes, that's the problem, (as also brought up in Alex's recent report).

So I've just pushed out a fixed version of the test case showing the
bug for the xlib backend. Interestingly, it also fails in a different
way with the ps backend.

And it's easy to confirm that your patch makes the xlib failure go
away, but I still suspect that the patch might be masking a larger
issue, (which the ps failure also suggests). So I'll chase the bogus
extents down a bit more before I push out the path.

> As long as it is in 1.4.0, I'll be happy.

Definitely. It's a nasty little bug, so we won't release without it
being fixed, (and the currently failing test case will help to ensure
that)

> I've been a bit of a pest about
> this bug since it is very visible in Flash renderings.

Thanks! We appreciate pests of that sort quite a bit!

> And it's not just
> rotated images, I also blame it for 1-pixel artifacts when rendering
> images to non-integer coordinates, as can be seen on the big red buttons
> at http://people.freedesktop.org/~company/stuff/youtube.png for example.
> Those magically went away after I applied my patch.

Cool, even more fixes for free! We'll want to ensure that that
behavior is also cleaned up by whatever the final patch is on this.

Thanks again,

-Carl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/cairo/attachments/20070126/033bf140/attachment.pgp