[cairo] X crash with BadAlloc with too-large pixmap

[Behdad Esfahbod]

On Mon, 2008-06-30 at 10:32 -0700, Vladimir Vukicevic wrote:
> Don't think I got a response last time -- any thoughts on this?  The  
> fix seems reasonable to me, though I'd probably change the function  
> name to _cairo_safe_XCreatePixmap or somesuch.

Good to go.  Please file a bug against GTK+ too.

Thanks

behdad

>      - Vlad
> 
> On Mar 26, 2008, at 4:07 PM, Vladimir Vukicevic wrote:
> 
> >
> > It seems to be possible to crash the xlib backend by trying to create
> > an image with dimensions grater than SHRT_MAX, as would be expected
> > due to X's limits.  Mats has a fix for this in bug https://bugzilla.mozilla.org/show_bug.cgi?id=424333
> >  -- essentially, it wraps XCreatePixmap to something that checks
> > width/height and returns an error in that case.  Does that seem like a
> > reasonable fix?
> >
> >     - Vlad
> >
> > _______________________________________________
> > cairo mailing list
> > cairo at cairographics.org
> > http://lists.cairographics.org/mailman/listinfo/cairo
> 
> _______________________________________________
> cairo mailing list
> cairo at cairographics.org
> http://lists.cairographics.org/mailman/listinfo/cairo
-- 
behdad
http://behdad.org/

"Those who would give up Essential Liberty to purchase a little
 Temporary Safety, deserve neither Liberty nor Safety."
        -- Benjamin Franklin, 1759