[cairo] A theme (and challenge) for 1.8.2: Eliminating XFAILs!

[Craig Bradney]

On Tuesday 21 October 2008 00:16:28 Craig Bradney wrote:
> On Tuesday 21 October 2008 00:03:34 Carl Worth wrote:
> > On Tue, 2008-10-14 at 16:29 -0700, Carl Worth wrote:
> > > So here are my two questions for everybody:
> > >
> > > 1. Is there anything in current cairo master that should be fixed
> > > before 1.8.2 ?
> >
> > Behdad has requested I drop the "internal font face" commits. I think
> > that means these:
> >
> > 	commit d5a998387bcee6569d33375d592190f480f12712
> > 	Author: Behdad Esfahbod <behdad at behdad.org>
> > 	    Add an internal font face
> >
> > 	commit f8542dc9dd4dd0685f68381f21fa72dbddd8d682
> > 	Author: Behdad Esfahbod <behdad at behdad.org>
> > 	    [twin-font] Clean up font data by joining lines and closing paths
> >
> > 	commit 9662be8ee77e219908b64b82e828d577dcf120f0
> > 	Author: Behdad Esfahbod <behdad at behdad.org>
> > 	    [twin-font] Adjust ascent/descent
> >
> > 	commit 6578ac148ecdd236b0860923e5dee87291c9966c
> > 	Author: Behdad Esfahbod <behdad at behdad.org>
> > 	    [twin-font] Make the stroke lighter
> >
> > 	commit 8cf399b944294645833088ee2ac1313093948b66
> > 	Author: Chris Wilson <chris at chris-wilson.co.uk>
> > 	    [test] Add a test to exercise the internal twin font
> >
> > So I'll rebase current master to make a new 1.8 branch that elides those
> > three commits, (and any others that I find are required0.
> >
> > > 2. Is there anything that's not yet in cairo master that should be
> > > added before 1.8.2?
> >
> > Since I asked, Chris has pushed out a lot of locking fixes based on
> > lockdep testing. It's always a bit scary to see MUTEX_LOCK/UNLOCK
> > changes right before a release, but I'm more comfortable that these are
> > based on problems and solutions verified with an automatic tool. And
> > it's lovely to see thing like:
> >
> > 	assert (CAIRO_HOLDS_MUTEX (scaled_font->mutex));
> >
> > throughout the code. This makes the code more readable, and isn't just
> > decoration, but is the condition verified by lockdep.
> >
> > I've also read through the big batch of changes that Chris just pushed,
> > and I'm willing to signoff on them.
> >
> > Chris has said he has one last issue to fix, but I haven't heard
> > anything from anyone else. So once he says he's done, I'll go ahead and
> > create 1.8.2 as described above.
>
> Was there ever a fix put in for the cairo bug shown in Scribus where faint
> lines were drawn on the canvas? http://bugs.scribus.net/view.php?id=6971
> Franz ended up working around this somehow but its a bit of a hack IIRC.


Thanks, :), we have confirmed the fix and only include our hack for > cairo 
1.5.10 && < cairo 1.8.0 now.

Craig
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.cairographics.org/archives/cairo/attachments/20081022/fadcc4da/attachment.htm