[cairo] [PATCH] Fix _cairo_region_get_boxes usage

Vladimir Vukicevic vladimir at pobox.com
Mon Feb 23 17:22:09 PST 2009

On 2/15/09 4:17 PM, Chris Wilson wrote:
> On Mon, 2009-02-16 at 01:03 +0100, Soeren Sandmann wrote:
>> Here is a patch to do that. It's a net reduction of 56 lines, and most
>> callers are much simpler.
> Thank you Soren, that looks a vast improvement over the current
> get_boxes().

I'm a little late to this party, but this replaces a quick loop with a 
function call per iteration; it probably won't matter assuming that the 
number of rectangles is low, but internally I'd rather see us optimize 
for speed even at the cost of added complexity.  If we don't, we risk 
death-by-a-thousand-cuts style performance degradation...

    - Vlad

More information about the cairo mailing list