[cairo] [PATCH] A set of NEON blitters for Pixman.

Jeff Muizelaar jeff at infidigm.net
Thu Jun 4 09:36:20 PDT 2009


On Thu, Jun 04, 2009 at 03:18:02PM +0300, Jonathan Morton wrote:
> > > Ah, I see the real bug.  It's a one-liner - r5 is being sourced
> > > explicitly instead of the %[width] reference.  It's probably a
> > > copy-paste bug, not spotted because I didn't originally write it.
> > 
> > This small piece of code actually happened to have two bugs. In addition to
> > using r5 register incorrectly, it just does not advance the destination
> > pointer (r4 register).
> 
> Ah.  I'd forgotten about that subtlety - that the NEON addressing modes
> are more like LDMIA/STMIA addressing modes, and that LDR/STR are
> different.
> 
> The two patches attached should, together, fix the problem finally.

Pushed.

-Jeff


More information about the cairo mailing list