[cairo] [RFC] Remove client-side workarounds

Clemens Eisserer linuxhippy at gmail.com
Sun May 17 13:41:42 PDT 2009


Hi Thomas,

Did you run the tests on an i915-class hardware?
I've filed a two reports (one now open for almost a year) which could
describe the problem causing the fails:

https://bugs.freedesktop.org/show_bug.cgi?id=16917
https://bugs.freedesktop.org/show_bug.cgi?id=17933

No idea if this is related:
https://bugs.freedesktop.org/show_bug.cgi?id=21523

- Clemens

2009/5/15 Thomas Jaeger <thjaeger at gmail.com>:
> Sorry, I forgot to regenerate the patches after adding a few comments to
> the commits.
>
> Thomas Jaeger wrote:
>> These are various performance fixes for cairo moving operations
>> (composite, gradients) from the client to the server, which avoid an
>> expensive transfer of a pixmap over the wire.  For handing off gradient
>> creation to Render, I've adapted an old patch of David Reveman:
>>
>> http://cgit.freedesktop.org/~anholt/cairo/log/?h=server-gradients
>>
>> Especially the first patch is important, since currently it is
>> prohibitively expensive for example for firefox to use linear
>> interpolation for image upscaling due to the client-side fallback.
>>
>> On my system, this causes only one additional test (extend-pad-border)
>> to fail in the cairo test suite.  The expected and actual output look
>> identical, so this could be a subpixel offset in the intel driver.
>> Certainly not something we need to worry about very much considering how
>> many of the tests fail on current master.
>>
>> An important question is when to use Render for Pad/Reflect (see the
>> commit message of the first patch), as we can't detect whether the X
>> server is using a broken driver and/or pixman version.  I haven't
>> implemented any checks for now, mainly because I'm unsure about which X
>> server version would be reasonably safe.
>>
>> Thanks,
>> Tom
>>
>
>
> _______________________________________________
> cairo mailing list
> cairo at cairographics.org
> http://lists.cairographics.org/mailman/listinfo/cairo
>


More information about the cairo mailing list