[cairo] [pixman] potential ARM/thumb interworking issue in Windows CE

[Jeff Muizelaar]

I'll give this a shot.

-Jeff

On 13-Feb-10, at 5:30 PM, Siarhei Siamashka wrote:

> Hello,
>
> http://cgit.freedesktop.org/pixman/commit/?id=2423118e239e9c85dd68403bf8b97b30965df38e
>
>> +++ b/pixman/pixman-arm-detect-win32.asm
>> @@ -0,0 +1,10 @@
>> + area pixman_msvc, code, readonly
>> +
>> + export pixman_msvc_try_armv6_op
>> +
>> +pixman_msvc_try_armv6_op
>> + uqadd8 r0,r0,r1
>> + mov pc,lr
>
> This "mov pc,lr" instruction was caught by an automated scanner for  
> potential
> thumb interworking problems. It was spotted by ubuntu developers and  
> discussed
> at irc.freenode.net #ubuntu-arm a few days ago.
>
> While this file is not used and thus has no impact in linux,  
> suppressing the
> alarm would be nice. Search in the Internet suggests that thumb may  
> be used in
> Windows CE systems too (I have no clue about ARM based windows systems
> myself): http://msdn.microsoft.com/en-us/library/ms937352.aspx
>
> The fix would probably just require a trivial change "mov pc,lr" ->  
> "bx lr".
> Could somebody try this change in windows and check whether it would  
> be ok?
>
>> + endp
>> +
>> + end
>
> -- 
> Best regards,
> Siarhei Siamashka