[cairo] Bug in cairo_tee_surface_create?

[Andrea Canciani]

On Fri, Jan 14, 2011 at 10:08 PM, Robert O'Callahan
<robert at ocallahan.org> wrote:
> On Fri, Jan 14, 2011 at 4:07 PM, Benjamin Otte <otte at redhat.com> wrote:
>>
>> Looks right to me. I fixed the wrapper stuff late in the 1.9 cycle for
>> subsurfaces and this seems like nobody fixed tee.
>>
>> We really need to add it to the testsuite...
>>
>> Do you have commit access and can push the patch?
>
> I don't.

I pushed the patch to cairo/master and cairo/1.10:

commit 922bbd432011728304fe5647467545a52b9ab9b0
Author: Robert O'Callahan <robert at ocallahan.org>
Date:   Tue Jan 18 13:52:21 2011 +0100

    tee: Do not apply two times the master device transform

    cairo_tee_surface_create copies the device transform from 'master' to
    the new surface. This is wrong since all the cairo_surface_wrapper
    functions apply master's device transform themselves.

    Reviewed-by: Benjamin Otte <otte at redhat.com>

Andrea

>
> Rob
> --
> "Now the Bereans were of more noble character than the Thessalonians, for
> they received the message with great eagerness and examined the Scriptures
> every day to see if what Paul said was true." [Acts 17:11]
>
> --
> cairo mailing list
> cairo at cairographics.org
> http://lists.cairographics.org/mailman/listinfo/cairo
>