[cairo] [patch] Accelerate CAIRO_BITSWAP8 on 64 bit machines

Xing, Dongsheng dongsheng.xing at intel.com
Tue May 29 01:29:07 PDT 2012


> -----Original Message-----
> From: Chris Wilson  
> Sent: Tuesday, May 29, 2012 4:00 PM
> To: Xing, Dongsheng; cairo at cairographics.org
> Subject: Re: [cairo] [patch] Accelerate CAIRO_BITSWAP8 on 64 bit machines
> > From: Chris Wilson
> > Sent: Tuesday, May 29, 2012 3:25 PM
> > To: Xing, Dongsheng; cairo at cairographics.org
> > Subject: Re: [cairo] [patch] Accelerate CAIRO_BITSWAP8 on 64 bit 
> > machines
> > 
> > > On Tue, 29 May 2012 02:03:58 +0000, "Xing, Dongsheng" wrote:
> > > > Hi, CAIRO_BITSWAP8 costs seven operations on a 32 bit machine, but 
> > > > it can be done with only four operations on 64 bit machines.
> > > > This patch accelerates CAIRO_BITSWAP8 on 64 bit machines.
> > >
> > > This doesn't apply to master. Care to resend?
> 
> It justs means that the parent of this patch is not known upstream and by my repository so git can not reconstruct the right patch for me.
> > > A more appropriate test here would be that "SIZEOF_LONG_LONG >= 8" as that is the condition used in the macro.
> 
> > I think SIZEOF_LONG >= 8 is better. Because sizeof(long long)==8 on a 32 bit machine. And SIZEOF_LONG is the length of a native processor word.
> Ok, if we can use SIZEOF_LONG here, wouuld 0x80200802LU suffice?
> -Chris

Yes, 0x80200802LU is suffice. The patch has been modified accordingly. The patch is now known upstream.
Best regards,
Dongsheng



More information about the cairo mailing list