[cairo] [patch 2/2] image: do not claim ownership of image data

Henry (Yu) Song - SISA hsong at sisa.samsung.com
Fri Feb 1 15:01:26 PST 2013

Hi, Chris

it causes double free crash.



From: cairo-bounces+henry.song=samsung.com at cairographics.org [cairo-bounces+henry.song=samsung.com at cairographics.org] on behalf of Chris Wilson [chris at chris-wilson.co.uk]
Sent: Friday, February 01, 2013 2:28 PM
To: Henry (Yu) Song - SISA
Cc: cairo at cairographics.org
Subject: Re: [cairo] [patch 2/2] image: do not claim ownership of image data

On Fri, Feb 01, 2013 at 10:10:16PM +0000, Henry (Yu) Song - SISA wrote:
> From 40db98e1dc3b882c0f071e0b6be35b5e6a563327 Mon Sep 17 00:00:00 2001
> From: Henry Song <henry.song at samsung.com>
> Date: Fri, 1 Feb 2013 13:23:19 -0800
> Subject: [PATCH 2/2] image: Do not claim ownership of the image data
> In _cairo_image_surface_create_from_image(), once pixman_image is
> created, the pixman owns the data, cairo_image_surface should not
> claim the ownership of created image data

If we allocate the pixels and pass the pointer to pixman, we own the
memory and are required to free it. We only allocate in the
circumstances were we need to override the normal stride.

Chris Wilson, Intel Open Source Technology Centre
cairo mailing list
cairo at cairographics.org

More information about the cairo mailing list