[cairo] Test case "bitmap-font" broken

Behdad Esfahbod behdad at behdad.org
Mon Mar 18 11:19:35 PDT 2013


Hi Uli,

Sorry about that.  Pushed out a fix.

behdad

On 13-03-18 02:06 PM, Uli Schlachter wrote:
> Hi Behdad,
> 
> thanks to Darxus, I started looking into the failure of the "bitmap-font" test.
> This test uses the font "test/6x13.pcf" that is shipped with the test suite and
> verifies its font extents.
> 
> I am writing to you, because the following commit made this test fail, according
> to git bisect:
> 
> commit b94a519aad3d5b50aa6de47ee16ee6a099de9791
> Author: Behdad Esfahbod <behdad at behdad.org>
> Date:   Fri Dec 21 18:40:08 2012 -0500
> 
>     [ft] Fix resizing of bitmap fonts
> [...]
> 
> The test expects font extents of e.g. ascent=11, descent=2, height=13. However,
> since this commit, the reported font extents are ascent=8.46154,
> descent=1.53846, height=10, as reported by test/output/bitmap-font.log. So all
> values are off by a factor of 10/13.
> 
> I don't have much clue about this, but to me the file name sounds like this font
> really should have a height of 13.
> 
> Since I don't have much clue about font handling, could you take a look and
> hopefully come up with a fix for this (e.g. deciding that the new values are
> correct and changing the test case for this)?
> 
> Thanks,
> Uli
> 

-- 
behdad
http://behdad.org/


More information about the cairo mailing list