[cairo] [PATCH] src and test: Fix issues reported by cppcheck static analysis tool

Chris Wilson chris at chris-wilson.co.uk
Thu Aug 21 03:17:01 PDT 2014

On Thu, Aug 21, 2014 at 03:21:35PM +0530, Ravi Nanjundappa wrote:
> cppcheck analysis tool reports the following issues when run on the
> latest Cairo source.
> $ grep "(error)"  cppcheck_error_log.txt
> [src/skia/cairo-skia-surface.cpp:245]: (error) Memory leak: surface
> [test/pdf-mime-data.c:58]: (error) Possible null pointer dereference: file - otherwise it is redundant to check if file is null at line 53
> [test/pdf-mime-data.c:75]: (error) Resource leak: fp
> $
> The proposed changes fixes the above issues.
> Signed-off-by: Ravi Nanjundappa <nravi.n at samsung.com>

Split it up into patches, and then you can add my
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

Chris Wilson, Intel Open Source Technology Centre

More information about the cairo mailing list