[cairo] [PATCH 4/8] xml: Don't assert on unsupported mesh and raster source patterns

Chris Wilson chris at chris-wilson.co.uk
Sat Feb 22 03:04:00 PST 2014


On Sat, Feb 22, 2014 at 02:07:06AM +0000, Bryce W. Harrington wrote:
> This quells the following warnings:
> 
>   src/cairo-xml-surface.c:722:5: warning: enumeration value
>   ‘CAIRO_PATTERN_TYPE_MESH’ not handled in switch
>   src/cairo-xml-surface.c:722:5: warning: enumeration value
>   ‘CAIRO_PATTERN_TYPE_RASTER_SOURCE’ not handled
>   in switch
> 
> I didn't find matching routines to handle these recently added enums, so
> gather they're unsupported in xml.  But we probably shouldn't crash if
> they're present.

No. The warning is telling us to implement the missing code, not to
simply silence it.

The assert is so that someone will eventually complain.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the cairo mailing list