[cairo] [PATCH] xcb: make use of _cairo_surface_is_xcb to check for surface type

RAVI NANJUNDAPPA nravi.n at samsung.com
Thu Jul 3 04:58:49 PDT 2014


Thank you Uli for reviewing this patch. 
Please find attached the patch updated with the changes to take care of the
cairo coding style.

Thanks and Best Regards, 
N Ravi

> -----Original Message-----
> From: Uli Schlachter [mailto:psychon at znc.in]
> Sent: Thursday, July 03, 2014 5:18 PM
> To: RAVI NANJUNDAPPA; cairo at cairographics.org
> Subject: Re: [cairo] [PATCH] xcb: make use of _cairo_surface_is_xcb to
check
> for surface type
> 
> On 02.07.2014 10:46, RAVI NANJUNDAPPA wrote:
> > Hi,
> >
> > Please find attached the updated patch incorporated with review
> > comments from Uli.
> > Thanking him for taking time to review the patch.
> > Please help me in reviewing the attached patch.
> >
> > Thanks and Best Regards,
> > N Ravi
> >
> [...]
> 
> With one minor comment:
> 
> Reviewed-by: Uli Schlachter <psychon at znc.in>
> 
> > diff --git a/src/cairo-xcb-surface.c b/src/cairo-xcb-surface.c index
> > c900edc..3b0c422 100644
> > --- a/src/cairo-xcb-surface.c
> > +++ b/src/cairo-xcb-surface.c
> > @@ -1432,7 +1432,7 @@ cairo_xcb_surface_set_size (cairo_surface_t
> *abstract_surface,
> >      }
> >
> >
> > -    if (abstract_surface->type != CAIRO_SURFACE_TYPE_XCB) {
> > +    if (!_cairo_surface_is_xcb(abstract_surface)) {
> >  	_cairo_surface_set_error (abstract_surface,
> >  				  _cairo_error
> (CAIRO_STATUS_SURFACE_TYPE_MISMATCH));
> >  	return;
> 
> Here (and in the other change in cairo-xcb-surface.c) it should be "( !"
instead
> of "(!". Just to match the normal cairo coding style.
> 
> Uli
> --
> Homophobia - The fear that another man will treat you the way you treat
> women.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-xcb-make-use-of-_cairo_surface_is_xcb-to-check-for-s.patch
Type: application/octet-stream
Size: 3513 bytes
Desc: not available
URL: <http://lists.cairographics.org/archives/cairo/attachments/20140703/79270d5f/attachment.obj>


More information about the cairo mailing list