[cairo] [PATCH 0/7] Bunch of distcheck fixes
Bryce W. Harrington
b.harrington at samsung.com
Thu Mar 13 18:04:13 PDT 2014
I've gone ahead and pushed patches 1, 2, 3, 6, and 7 from this series to
Patch 4 I modified as suggested by Uri and pushed, to indicate skia has
been in the codebase since 1.10 rather than 1.12.
Patch 5 I dropped and used Uri's alternate fix instead, after checking
that it resolves the gtk-doc issues.
As mentioned below, there is still some minor cruft in distcheck, but
nothing IMHO that is worth holding up the release for. However, tests
are in a poor shape right now.
I ran 'make check' comparisons between the 1.12.8 release (as tagged in
git), and master HEAD from earlier today:
Tests run: 22751 24838
Passed: 15809 15881
Failed: 4198 5385
Expected Failed: 405 330
Error: 1 1
Crashed: 227 1018
Untested: 2111 2223
Total: 22751 24838
I've attached a listing of the test cases that changed their results.
Failures seem to be rather across the board, although there does seem to
be a lot relating to clipping/masking and transform/scaling.
On Wed, Feb 26, 2014 at 10:29:41PM +0000, Bryce W. Harrington wrote:
> With most of the build warnings squared away, here's a set of fixes for
> various problems encountered when running make distcheck.
> Largely these are documentation issues. I've filled in bits as best I
> could figure out, and moved things around a bit to make the doc checker
> happy, but I would certainly appreciate a close review. Some of the
> docs could benefit from a bit more elaboration by someone more familiar
> with the given code.
> I also had to make some judgment calls in adding Since fields to various
> API bits. I tried to find when the interface was first mentioned in
> NEWS, or lacking that tried to identify the date of introduction into
> git, and then assume it was part of the next major cairo release and
> used that number. Those numbers may be off; I don't know how critical
> these numbers are though. There may be cases where I've added versions
> but it really should be TBD; if you spot these let me know.
> This patch set cleans up nearly all the distcheck issues, but there's a
> few things remaining:
> * warning about uninitialized variables
> * warnings about inlining failures
> * warnings about ignored return values (Bugzilla #58727)
> * Lots and lots of test failures
> * rsvg_pixbuf_from_file is deprecated, so svg2png needs recoded a bit.
> * four unused CAIRO_HAS_*_FUNCTIONS declarations aren't included in
> * gtk-doc can't parse "SkBitmap::Config&" args so some skia functions
> aren't getting processed
> The first three we've discussed on the list and felt were pretty minor.
> The test failures need further analysis, and likely a lot more work.
> The gtk-doc issue I suspect is gtk-doc being confused by C++ code, and
> maybe not something to worry about; maybe a workaround would be enough.
> The other two issues are minor and probably more work to fix than worth.
> Bryce Harrington (7):
> doc: Add missing sections and symbols for public docs
> doc: Drop a couple quartz routines which distcheck claims don't exist
> Mark recently added _cairo_output_stream_print_matrix private symbol
> skia: Add section definitions and code docs for skia backend
> check-def: Fix code document errors
> surface: Make parameter naming consistent between header and impl
> Document that libglib2.0-doc is needed to avoid some xref warnings
> RELEASING | 4 +-
> doc/public/cairo-sections.txt | 42 +++++++++++++++++++--
> src/cairo-cache-private.h | 2 +
> src/cairo-output-stream-private.h | 2 +-
> src/cairo-raster-source-pattern.c | 2 -
> src/cairo-region.c | 16 +-------
> src/cairo-skia-surface.cpp | 21 +++++++++++
> src/cairo-surface-observer.c | 5 +++
> src/cairo-surface.c | 12 +++---
> src/cairo-types-private.h | 74 ++++++++++++++++++++-----------------
> src/cairo.h | 20 ++++++++++
> src/skia/cairo-skia-private.h | 19 ++++++++++
> 12 files changed, 158 insertions(+), 61 deletions(-)
More information about the cairo