[cairo] [PATCH 03/41] core: _canonical_box() allow NULL box ptr

Enrico Weigelt, metux IT consult enrico.weigelt at gr13.net
Sat Dec 12 09:02:39 PST 2015


On 12.12.2015 10:50, Uli Schlachter wrote:

> Ah, thanks for the info. I'd suggest adding "A later patch will use this with a
> NULL argument", or something like that.

okay, added it.

> Can't you just use a non-NULL argument here? 

would mean having an unnecesary copy ...

> Or, instead add an explicit NULL
> check to _cairo_path_fixed_is_box() so that it does not call _canonical_box() at
> all?

That's a good idea. Will be coming in next iteration.


--mtx

--
Enrico Weigelt,
metux IT consulting
+49-151-27565287


More information about the cairo mailing list