[cairo] [PATCH 12/43] drm: allow CAIRO_FORMAT_RGB30

Enrico Weigelt, metux IT consult enrico.weigelt at gr13.net
Wed Dec 16 03:02:34 PST 2015


On 15.12.2015 21:20, Lawrence D'Oliveiro wrote:
> On Tue, 15 Dec 2015 20:49:52 +0100, Enrico Weigelt, metux IT consult
> wrote:
> 
>> +    case CAIRO_FORMAT_RGB30:
>>  	cache->buffer.map0 = MAPSURF_32BIT | MT_32BIT_ARGB8888;
> 
> I assume the code is not actually looking at the pixel components,
> otherwise this cannot be correct.

Well, I'm a bit naive at this point - I just assmed that on RGB30
the upper two bits are just zero (and it's still 4 byte per pixel)

OTOH, we could just declare rgb30 as unsupported.
What's your oppinion ?


--mtx

--
Enrico Weigelt,
metux IT consulting
+49-151-27565287


More information about the cairo mailing list