[cairo] [PATCH 0/5] Refactoring to avoid namespace collision on AIX

Bryce Harrington bryce at osg.samsung.com
Thu Jun 18 12:57:38 PDT 2015

On Wed, Jun 17, 2015 at 10:31:47AM +0100, Chris Wilson wrote:
> On Wed, Jun 17, 2015 at 02:05:35AM -0700, Bryce Harrington wrote:
> > This patchset initiated as a fix for bug #89339.  The actual fix is the
> > last patch in the patchset.  Some of the proposed fixes really just
> > worked around the actual problem, yet none-the-less were worthwhile
> > refactorings that would cleanup the code, so are submitted along with
> > the fix.
> > 
> > Bryce Harrington (5):
> >   cairo-script: Always include config.h first thing
> >   cairo-script: Add missing copyright and boilerplate
> >   cairo-script: Cleanup boilerplate header for consistency
> >   cairo-script: Prefer cairo from local tree
> >   cairo-script: Rename struct member to avoid name collision on AIX
> Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
> Note that we have used #ifdef HAVE_CONFIG_H universally, but since we
> control the build system we should probably depend on it like 1/5 here.

Do you mean that in other places in the cairo codebase we should be
depending on config.h directly (without the cpp conditional)?  Or just
here in the util module?

Thanks for the review, pushed:


> -Chris
> -- 
> Chris Wilson, Intel Open Source Technology Centre

More information about the cairo mailing list