[cairo] [PATCH 24/72] drm: fixed const constraints

Bryce Harrington bryce at osg.samsung.com
Fri Jan 15 13:00:23 PST 2016

On Fri, Jan 15, 2016 at 09:55:01PM +0100, Enrico Weigelt, metux IT consult wrote:
> On 15.01.2016 21:41, Bryce Harrington wrote:
> > On Tue, Dec 29, 2015 at 10:17:02AM +0100, Enrico Weigelt, metux IT consult wrote:
> >> Signed-off-by: Enrico Weigelt, metux IT consult <enrico.weigelt at gr13.net>
> > 
> > In general I love seeing const added everywhere possible, just that I'm
> > concerned about any risk in breaking ABI's.  The changelog entry needs
> > to specify that these changes either don't affect any externally
> > accessible ABI/API's, or that const'ing them won't cause any breakage
> > either in C or C++.  Otherwise, it needs to explain why we don't care
> > about causing such breakage in this case.
> These are just internal functions of the DRM backend(s). And the const
> constraints are dictated by surface backend API. I'm just fixing the
> (long time unmaintained) DRM backend functions to match the API.

Fair enough, if you add that to the changelog entry you can add:

Reviewed-by: Bryce Harrington <bryce at osg.samsung.com>

More information about the cairo mailing list