[cairo] GCC warning: correct?

David Kastrup dak at gnu.org
Sun Jun 25 19:10:21 UTC 2017


David Kastrup <dak at gnu.org> writes:

> cairo-surface.c: In function ‘cairo_surface_create_similar’:
> cairo-surface.c:508:5: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
>      if (unlikely (! CAIRO_CONTENT_VALID (content)))
>      ^~
> cairo-surface.c:511:9: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the ‘if’
>          if (unlikely (other->status))
>          ^~
>
>

And another one?

cairo-script-operators.c: In function ‘_set_dash’:
cairo-script-operators.c:4813:2: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
  if (_csi_unlikely ((unsigned) array->stack.len >= INT_MAX / sizeof (double)))
  ^~
cairo-script-operators.c:4815:6: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the ‘if’
      dashes = _csi_alloc (ctx, sizeof (double) * array->stack.len);
      ^~~~~~



-- 
David Kastrup



More information about the cairo mailing list