[cairo] OpenType font variations and cairo
matthias.clasen at gmail.com
Thu Sep 14 23:59:55 UTC 2017
On Thu, Sep 14, 2017 at 5:54 PM, Adrian Johnson <ajohnson at redneon.com>
> On 15/09/17 05:52, Matthias Clasen wrote:
> > On Thu, Sep 14, 2017 at 12:37 PM, Behdad Esfahbod
> > <behdad.esfahbod at gmail.com <mailto:behdad.esfahbod at gmail.com>> wrote:
> > Thanks Matthias. I took a look at the patch. Looks good! Minor
> > comments:
> > - Moving the format towards CSS by default (no comma, no equal sign;
> > just spaces!) while accepting both is what I do in HarfBuzz. Maybe
> > advertise the same here, UPDATE: I was wrong. CSS uses comma as
> > well. It's the equal sign that they don't use, they use space. We
> > should accept both.
> > I've made the parser a bit more flexible. It now accepts variations like
> > wdth=200,wght=300
> > wdth 200, wght=300
> > wdth 200 , wght 300
> Does it work with decimal commas?
The patch currently uses strtod, so yes, it will parse floating point
numbers, but decimal separators spell trouble.
I could rewrite it to use strtod_l, if that is ok to use in cairo.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the cairo