[cairo] OpenType font variations and cairo
matthias.clasen at gmail.com
Tue Sep 19 13:25:24 UTC 2017
On Tue, Sep 19, 2017 at 8:41 AM, Adrian Johnson <ajohnson at redneon.com>
> On 19/09/17 21:02, Matthias Clasen wrote:
> > On Tue, Sep 19, 2017 at 7:04 AM, Adrian Johnson <ajohnson at redneon.com
> > <mailto:ajohnson at redneon.com>> wrote:
> > On 18/09/17 01:03, Matthias Clasen wrote:
> > > On Sun, Sep 17, 2017 at 1:12 AM, Adrian Johnson <
> ajohnson at redneon.com <mailto:ajohnson at redneon.com>
> > > <mailto:ajohnson at redneon.com <mailto:ajohnson at redneon.com>>>
> > > I've attached a patch that refactors the float parsing code
> > > cff-subset into a new function: _cairo_strtod(). So you can
> now use this
> > > for a C locale strtod.
> > >
> > >
> > > Yay, thanks.It might still be nice to apply the strtod_l patch on
> > > and only use that code as fallback.
> > -1. Just use the cairo_strtod all the time. We don't use non ANSI C
> > functions with #include guarded fallbacks in cairo. It adds to source
> > code bloat and one side of the #if won't get regularly tested.
> > I disagree, at least in this case, but your call.
> We don't do it that way in cairo. If the fallback works just use it all
> the time.
Fine. Easy enough to drop that commit.
> I did some more testing. With my system fontconfig (2.11) the test
> failed (same result) when using the ttf font. FC 2.11 did not recognize
> the otf font.
> I tested fontconfig 2.12.5. The test crashed with both the ttf and otf
> fonts due to a divide by zero error.
> What version of FC are you using and which font (otf or ttf)?
I have fontconfig 2.12.5 and freetype 2.8 on my system, and I am using the
ttf version of the font.
Behdad, does my test work on your system ?
Is there some printfs you could add to help debug this?
I'll think about it.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the cairo