[Clipart] Patch to add DMS support to upload script

Bryce Harrington bryce at bryceharrington.com
Mon Aug 29 09:47:45 PDT 2005


On Mon, Aug 29, 2005 at 08:05:42AM -0400, Jonadab the Unsightly One wrote:
> Bryce Harrington <bryce at bryceharrington.com> writes:
> 
> > Hi Jonadab,
> > 
> > I think everything's set for adding a call to DMS to the upload script,
> > like we talked about the other day.  Below is a patch which should add
> > this capability.
> 
> This is now live on the site.  I did make one change.  I changed ||=
> to just = so that the hardcoded value for the DMS bin directory
> overrides whatever may be in the config file.  This is for reasons
> having to do with taint checking, since we execute a binary from
> there, and Perl considers data that are read from a file to be tainted
> (which, usually, is right, although in this instance the script itself
> could be altered just as easily as the config file).

Actually, since we're installing DMS locally rather than as root, the
default path of /usr/bin won't work for us.

> This doesn't actually change anything right now in practice, since
> that value was not specified in the config file anyway.

Hmm, I thought I'd updated the config file.  Well here are the settings
that need to be added to that file:

dms_bin:                /srv/clipart.freedesktop.org/bin/
dms_log:		/srv/clipart.freedesktop.org/var/log/dms_upload.log

Thanks,
Bryce



More information about the clipart mailing list