[Cogl] [PATCH 2/2] Remove lots of legacy api depending on the default context

Neil Roberts neil at linux.intel.com
Wed May 16 04:54:50 PDT 2012


Just some minor points:

Robert Bragg <robert at sixbynine.org> writes:

> @@ -420,5 +418,8 @@ _cogl_blit (CoglBlitData *data,
>  void
>  _cogl_blit_end (CoglBlitData *data)
>  {
> +  cogl_object_unref (data->fb);

This framebuffer unref should be moved into
_cogl_blit_texture_render_end because it is only set if the texture
render method is used. Indeed it crashes if you run test-atlas-migration
with COGL_ATLAS_DEFAULT_BLIT_MODE set to a non-default value.

> +  cogl_object_unref (data->pipeline);

The pipeline created by the texture_render method shouldn't be unrefd
because it is globally shared on the CoglContext.

We could probably change it to use the null texture now and make a
temporary copy of the base pipeline instead of the mad things it is
doing now. But I guess that can be saved for a separate patch.

Otherwise looks good.

Reviewed-by: Neil Roberts <neil at linux.intel.com>

- Neil


More information about the Cogl mailing list